Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #52 and potentially #62 #65

Merged
merged 4 commits into from
Apr 23, 2020
Merged

Fix for issue #52 and potentially #62 #65

merged 4 commits into from
Apr 23, 2020

Conversation

tomaspinho
Copy link
Contributor

No description provided.

@sl1pm4t
Copy link
Owner

sl1pm4t commented Apr 21, 2020

Thanks @tomaspinho ! Any chance you could add a unit test in hcl_writer_test.go to validate the fix?

@tomaspinho
Copy link
Contributor Author

Hey @sl1pm4t ! Added the test cases, however the tests keep failing because of non-determinism in the resulting key order.

@sl1pm4t
Copy link
Owner

sl1pm4t commented Apr 23, 2020

Thanks @tomaspinho - yes, the non-deterministic key order is a known problem. It got worse recently with a golang version bump (I think). Thanks for the fix and the test!

@sl1pm4t sl1pm4t merged commit e8c0fd7 into sl1pm4t:master Apr 23, 2020
This was referenced Jun 4, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomaspinho @sl1pm4t